-
Notifications
You must be signed in to change notification settings - Fork 14
feat(design-tools): make applying-bitwarden-branding self-contained (build + review) #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
da4deea
feat(design-tools): scaffold bitwarden-design-tools plugin v0.1.0
SaintPatrck a274fcd
feat(design-tools): add brand tokens, canonical lockup assets, skill β¦
SaintPatrck 8a98768
feat(design-tools): register bitwarden-design-tools v0.1.0 in marketpβ¦
SaintPatrck 32e45f7
feat(design-tools): expand applying-bitwarden-branding to build + review
SaintPatrck b12df1a
Merge origin/main into feat/bitwarden-design-tools
SaintPatrck 07a136b
chore(design-tools): fold brand-assets.md into logo-usage.md
SaintPatrck d1197d8
fix(design-tools): address skill review on applying-bitwarden-branding
SaintPatrck d2cbacc
style(design-tools): apply prettier formatting
SaintPatrck 373ea42
fix(design-tools): correct yellow in example one-pager (#FFD700 -> #Fβ¦
SaintPatrck af5855d
refactor(design-tools): drop redundant 'What this skill is for' section
SaintPatrck b86f824
feat(design-tools): add surface short-circuit to applying-bitwarden-bβ¦
SaintPatrck 6e55095
refactor(design-tools): brand-canon script is verify-and-report only
SaintPatrck 183fe6e
feat(design-tools): pre-authorize verify-brand-canon.sh via allowed-tβ¦
SaintPatrck 5a4ec95
feat(design-tools): pre-authorize reading bundled references and assets
SaintPatrck cd0213f
refactor(design-tools): move on-brand-one-pager example into the skill
SaintPatrck 03a47dc
refactor(design-tools): trust bundled filenames instead of pre-authinβ¦
SaintPatrck 1b20fe2
refactor(design-tools): tighten branding skill scope per review
SaintPatrck ee0b6fe
docs(design-tools): drop CI allusion from drift script
SaintPatrck 4416a9f
test(design-tools): track lean eval harness for applying-bitwarden-brβ¦
SaintPatrck aa4994a
fix(design-tools): correct radius-on-full-bleed and default to dark mode
SaintPatrck f06a6df
test(design-tools): de-bias eval fixtures
SaintPatrck 796b94f
test(design-tools): neutralize eval fixture filenames
SaintPatrck a62ab37
test(design-tools): make the FP control fixture genuinely canon-complβ¦
SaintPatrck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "bitwarden-design-tools", | ||
| "version": "0.1.0", | ||
| "version": "0.2.0", | ||
| "description": "Design toolkit for Bitwarden β non-persona skills for the design lifecycle. Content style guide reference, Figma Dev Mode MCP usage, Bitwarden brand application, design-to-engineering handoff prep, Design System governance, and the Product and Design Jira workflow. Composed by the bitwarden-designer agent and usable standalone.", | ||
| "author": { | ||
| "name": "Bitwarden", | ||
|
|
@@ -18,6 +18,9 @@ | |
| "design-system", | ||
| "brand", | ||
| "branding", | ||
| "accessibility" | ||
| "accessibility", | ||
| "deliverable", | ||
| "html", | ||
| "dashboard" | ||
|
Comment on lines
+22
to
+24
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. β Are these useful? They come off as really generic to me.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably not. More likely to trigger false-positives than actually help. Will remove. |
||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
βοΈ We alphabetize this.