Move architecting-solutions from bitwarden-tech-lead to bitwarden-delivery-tools#160
Move architecting-solutions from bitwarden-tech-lead to bitwarden-delivery-tools#160trmartin4 wants to merge 9 commits into
Conversation
…n-delivery-tools Lets delivery-lifecycle skills (breakdowns, initiative-funnel work, ownership transitions) invoke architectural judgment directly without requiring users to install bitwarden-tech-lead. - bitwarden-delivery-tools 2.0.0 -> 2.1.0 (new skill; git rename) - bitwarden-tech-lead 2.3.2 -> 3.0.0 (skill removed; AGENT.md points at new location) - SKILL.md: dropped shepherd section, contributing-to-technical-strategy cross-reference, and two of five Architecture-involvement signals; repaired paragraph structure and voice in the Architecture-Group section; made Skill(threat-modeling) reference explicit
Plugin Validation Summary — PR #160Result: ✅ PASS — no critical, major, or errors-that-must-fix issues found. Two optional minor observations are noted below. This PR moves the What was validated
1. Plugin Structure — ✅ PASS (all three plugins)
Semver bumps are correct: MINOR for delivery-tools (added skill), MAJOR for tech-lead (breaking removal), PATCH for shepherd (reference-only). No hardcoded credentials in any plugin file. Core move verification:
2. Skill Review — ✅ PASSWord counts all within the 1,000–3,000 target band: architecting-solutions 1,046, running-a-proof-of-concept 2,056, running-an-architectural-assessment 1,513.
Repo-wide stale-reference sweep: every 3. Security — ✅ PASS (clean)
Optional minor observations (non-blocking, do not require action for this PR)
Recommendation: APPROVE. No changes are required for this PR to merge. |
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the relocation of the Code Review DetailsNo new findings. The two prior suggestions on |
- tech-lead README: drop architecting-solutions from Skills table; add it to the delivery-tools cross-plugin row; rewrite upgrade note to reflect the skill's new home - delivery-tools README: add architecting-solutions to the Technical design table; extend the concern description; add a Related Plugins section covering the atlassian-tools and security-engineer cross-plugin dependencies - tech-lead CHANGELOG 3.0.0: note the README updates
trmartin4
changed the title
Skill(architecting-solutions) moved from bitwarden-tech-lead to bitwarden-delivery-tools in the sibling PR. Shepherd docs and skills still resolved by name, but instructed users to reach for tech-lead to get a skill it no longer provides. - README, AGENT.md: move architecting-solutions from the tech-lead cross-plugin row into the delivery-tools row - running-an-architectural-assessment, running-a-proof-of-concept: update inline and Related-links references - 1.0.0 -> 1.0.1 (patch; docs-only)
SaintPatrck
left a comment
SaintPatrck
left a comment
There was a problem hiding this comment.
Left a couple of questions that are byproducts of not having evals associated with any of this. I don't want to hold the PR, but there would be real value in adding evals in a follow-up. Without them, reviewers have no way to verify if changes are improving or regressing behavior, and no way to identify whether we can remove excess commentary. Like submitting code changes without unit tests. We trust, but we also want to verify.
| allowed-tools: Skill, mcp__plugin_bitwarden-atlassian-tools_bitwarden-atlassian__get_issue, mcp__plugin_bitwarden-atlassian-tools_bitwarden-atlassian__get_issue_comments, mcp__plugin_bitwarden-atlassian-tools_bitwarden-atlassian__get_issue_remote_links, mcp__plugin_bitwarden-atlassian-tools_bitwarden-atlassian__search_issues, mcp__plugin_bitwarden-atlassian-tools_bitwarden-atlassian__get_confluence_page, mcp__plugin_bitwarden-atlassian-tools_bitwarden-atlassian__get_confluence_page_comments, mcp__plugin_bitwarden-atlassian-tools_bitwarden-atlassian__search_confluence, mcp__plugin_bitwarden-atlassian-tools_bitwarden-atlassian__search_confluence_cql | ||
| --- | ||
|
|
||
| This skill applies architectural judgment during team-level delivery work: scoping tickets, drafting breakdowns, evaluating trade-offs, and choosing between approaches. |
There was a problem hiding this comment.
❓ How did adding this statement change Claude's behavior?
There was a problem hiding this comment.
You're right. It doesn't meaningfully change it, it's not addressed to Claude but to a human. I removed it.
| Teams have autonomy over decisions inside their domain. Architecture doesn't gate-keep team-level work. What Architecture does is maintain the holistic view — the portfolio of cross-cutting initiatives, the patterns that span teams, the decisions that will be expensive to change later. The job at the team level is to recognize when a choice has implications that benefit from that wider view, and pull Architecture in before — not after — the team ships. | ||
|
|
||
| Watch for the five signals that warrant Architecture involvement (from the [Architecture / Engineering Operating Model](https://bitwarden.atlassian.net/wiki/spaces/EN/pages/1286963201)): | ||
| Watch for signals that warrant Architecture involvement (from the [Architecture / Engineering Operating Model](https://bitwarden.atlassian.net/wiki/spaces/EN/pages/1286963201)): |
There was a problem hiding this comment.
❓ Is Claude actually fetching this URL at any point, without explicit instruction to do so? Should it, so it is aware of the full decision model, or are we comfortable relying solely on the key points below? Is there concern with more drift between them? Does behavior degrade if this link is not present?
There was a problem hiding this comment.
I removed the URL as it wasn't serving any meaningful purpose.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
2 participants
📔 Objective
Moves the
architecting-solutionsskill frombitwarden-tech-leadintobitwarden-delivery-toolsso it can be invoked directly from delivery-lifecycle skills (breakdowns, initiative-funnel work, ownership transitions) without requiring users to installbitwarden-tech-lead. This also mirrors the shared organizational responsibility of designing solutions - it is not isolated to a tech lead role.As written previously, it would require anyone to install the tech-lead agent, which - given that all engineers are not tech leads and solution design is not a tech lead responsibility - presents a dissonance that would inhibit its invocation when potentially useful.
Removes references to the initiative shepherd, as this is a human-to-human process engaged outside of the solution architecture process, but kept a callout to engage with Architecture if we identify solution changes that warrant it.