[PM-40747] feat: Add vault folder delete and duplicate name validation#7194
Open
Ashishchidhava wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
Ashishchidhava
force-pushed
the
feature/folder-delete-and-duplicate-name-validation
branch
from
July 22, 2026 06:30
ca8b19e to
f2ebf89
Compare
Make folders manageable from My vault and prevent creating folders with the same name.
Ashishchidhava
force-pushed
the
feature/folder-delete-and-duplicate-name-validation
branch
from
July 22, 2026 06:30
f2ebf89 to
022d573
Compare
Author
|
Small cleanup note for reviewers: the example duplicate folder name in the description was just a local test string — happy to adjust copy or follow any Product/Engineering guidance on UX (e.g. overflow placement, delete confirmation wording). Happy to iterate quickly on any review feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Local enhancement: folders on My vault had no delete action, and creating folders with the same name was allowed (e.g. two folders both named “Himalya”).
📔 Objective
Improve folder management from My vault and prevent duplicate folder names.
1. Delete / edit folder from My vault
vaultRepository.deleteFolderand edit-folder navigation (no new delete API).2. Duplicate folder name validation
Parent/Child).FolderAddEditViewModel)VaultAddEditViewModel)foldersStateFlowso validation uses a loaded folder list (fixes a race where.valuewas often empty and duplicates were allowed).a_folder_with_this_name_already_exists→ “A folder with this name already exists.”3. Supporting UI / navigation
BitwardenGroupItemsupports an optional overflow selection list (used by vault folder rows).NavigateToEditFolderthrough vault → nav bar → unlocked graph.Tests
FolderAddEditViewModelTest: duplicate name blocked; edit with unchanged name still saves.VaultViewModelTest: folder edit navigation, delete confirmation, successful delete snackbar.onNavigateToEditFolderScreencallback.📸 Screenshots
Verified on device:
Test plan