Skip to content

[PM-40930] feat: Added log when fill assist is invoked - #7208

Merged
aj-rosado merged 1 commit into
mainfrom
PM-40930/fill-assist-flight-recorder-logs
Jul 24, 2026
Merged

[PM-40930] feat: Added log when fill assist is invoked#7208
aj-rosado merged 1 commit into
mainfrom
PM-40930/fill-assist-flight-recorder-logs

Conversation

@aj-rosado

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-40930

📔 Objective

Added a simple logging information indicating that the autofill attempt is using FillAssist.

@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label Jul 24, 2026
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the single-line change in AutofillParserImpl.kt that adds a Timber.d log when FillAssist is invoked during an autofill attempt (PM-40930). This is a low-risk diagnostic logging change that follows the file's existing conventions.

Code Review Details

No blocking findings.

  • Timber is already imported (line 23) and used at the same .d level elsewhere in this file (lines 120, 192) — the new line is stylistically consistent.
  • The log message is a static string with no sensitive data (no vault data, credentials, URIs, or host names), which matters given this is autofill parsing code.
  • The log is correctly placed inside the coversCurrentPartition branch, so it fires only when FillAssist views are actually built.

Non-blocking observation: the other two debug logs in this file append fillRequest?.id for request correlation. This new line has no correlating identifier, so it can't be tied back to a specific autofill attempt in the flight recorder. fillRequest isn't in scope in this helper, so this is only a soft note — worth considering if per-request correlation is a goal of the flight-recorder effort.

@aj-rosado aj-rosado changed the title [PM-40930] Added log when fill assist is invoked [PM-40930] feat: Added log when fill assist is invoked Jul 24, 2026
@aj-rosado aj-rosado added ai-review-vnext Request a Claude code review using the vNext workflow t:feature Change Type - Feature Development labels Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.91%. Comparing base (b2553be) to head (7052cfe).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7208      +/-   ##
==========================================
- Coverage   86.20%   85.91%   -0.29%     
==========================================
  Files         884      934      +50     
  Lines       64657    66629    +1972     
  Branches     9674     9732      +58     
==========================================
+ Hits        55737    57245    +1508     
- Misses       5456     5899     +443     
- Partials     3464     3485      +21     
Flag Coverage Δ
app-data 17.36% <100.00%> (-0.38%) ⬇️
app-ui-auth-tools 18.58% <0.00%> (-0.20%) ⬇️
app-ui-platform 17.02% <0.00%> (+0.46%) ⬆️
app-ui-vault 27.88% <0.00%> (+0.51%) ⬆️
authenticator 6.10% <0.00%> (-0.05%) ⬇️
lib-core-network-bridge 4.11% <0.00%> (+0.10%) ⬆️
lib-data-ui 1.18% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aj-rosado
aj-rosado added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit dd343e0 Jul 24, 2026
26 of 32 checks passed
@aj-rosado
aj-rosado deleted the PM-40930/fill-assist-flight-recorder-logs branch July 24, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants