Skip to content

[PM-38794] Add OrganizationInviteLinkApiService.getInvite#21932

Merged
JimmyVo16 merged 4 commits into
mainfrom
ac/pm-38794/add-getinviteblob
Jul 22, 2026
Merged

[PM-38794] Add OrganizationInviteLinkApiService.getInvite#21932
JimmyVo16 merged 4 commits into
mainfrom
ac/pm-38794/add-getinviteblob

Conversation

@JimmyVo16

@JimmyVo16 JimmyVo16 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38794

📔 Objective

Add OrganizationInviteLinkApiService.getInvite to call the API (Server PR)

@JimmyVo16 JimmyVo16 self-assigned this Jul 17, 2026
@JimmyVo16 JimmyVo16 added ai-review Request a Claude code review t:feature Change Type - Feature Development labels Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the addition of OrganizationInviteLinkApiService.getInvite, which calls the new POST /organizations/users/invite-link/invite server endpoint. The change adds a request model, a response model wrapping the opaque SDK Invite, barrel exports, the abstraction, and the default implementation. The new code faithfully mirrors established patterns in the organization-invite-link library — the response parsing matches OrganizationInviteLinkResponseModel, the send(...) argument shape matches the sibling create/refresh methods, and the body-based organizationId mirrors the accept endpoint's URL structure.

Code Review Details

No blocking findings.

Notes considered and intentionally not flagged:

  • Codecov reports 50% patch coverage: the API service class has no existing .spec.ts, so the untested getInvite is consistent with its sibling methods (create, refresh, get, accept) rather than a regression.
  • The opaque Invite is documented as an encrypted value the server never inspects; no vault data or secrets are logged.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.08%. Comparing base (3ea522e) to head (fd2e945).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...equests/organization-invite-link-invite.request.ts 33.33% 2 Missing ⚠️
...ponses/organization-invite-link-invite.response.ts 50.00% 2 Missing ⚠️
...es/default-organization-invite-link-api.service.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21932      +/-   ##
==========================================
+ Coverage   52.04%   52.08%   +0.03%     
==========================================
  Files        4099     4110      +11     
  Lines      129754   130108     +354     
  Branches    20351    20404      +53     
==========================================
+ Hits        67532    67761     +229     
- Misses      57242    57353     +111     
- Partials     4980     4994      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JimmyVo16
JimmyVo16 marked this pull request as ready for review July 20, 2026 13:25
@JimmyVo16
JimmyVo16 requested a review from a team as a code owner July 20, 2026 13:25
@JimmyVo16
JimmyVo16 requested review from eliykat and r-tome July 20, 2026 13:25
@JimmyVo16
JimmyVo16 merged commit 5740070 into main Jul 22, 2026
143 of 146 checks passed
@JimmyVo16
JimmyVo16 deleted the ac/pm-38794/add-getinviteblob branch July 22, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants