Skip to content

[PM-31743] Remove unused service account section from _helpers.tpl#450

Open
brookelew wants to merge 1 commit into
bitwarden:mainfrom
brookelew:remove-unused-service-account-defines
Open

[PM-31743] Remove unused service account section from _helpers.tpl#450
brookelew wants to merge 1 commit into
bitwarden:mainfrom
brookelew:remove-unused-service-account-defines

Conversation

@brookelew

@brookelew brookelew commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-31743

📔 Objective

Remove unused section in _helpers.tpl used to configure the service account name, which references keys no longer present in values.yml, and which has no effect on the rendered chart.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@brookelew
brookelew requested a review from a team as a code owner February 5, 2026 00:41
@brookelew
brookelew requested review from mimartin12 and removed request for a team February 5, 2026 00:41
@bitwarden-bot

Copy link
Copy Markdown

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-31743
Link: https://bitwarden.atlassian.net/browse/PM-31743

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title Remove unused service account section from _helpers.tpl [PM-31743] Remove unused service account section from _helpers.tpl Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants