[PM-39978] Add Item type Send support#8008
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the addition of the Code Review Details
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8008 +/- ##
==========================================
+ Coverage 62.23% 62.51% +0.28%
==========================================
Files 2287 2298 +11
Lines 99665 100050 +385
Branches 9004 9026 +22
==========================================
+ Hits 62024 62550 +526
+ Misses 35470 35319 -151
- Partials 2171 2181 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
harr1424
left a comment
There was a problem hiding this comment.
Minor suggestions and outstanding question on unexpectedly large EncryptedStringLength
harr1424
left a comment
There was a problem hiding this comment.
Changes look good but I believe a doc comment is out of date
Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-39978
📔 Objective
This PR is the first step in the Temporary Item Sharing effort. This PR allows the server to accept Sends of type Item by adding a new value to the SendType enum and handling it in associated Send code. Since these new Item Sends will be blob-encrypted instead of field by field we also add a new
Dataproperty to the Send request model that allows clients to pass the entire encrypted payload (this field will also be usable when we eventually migrate Text and File Sends to do the same). Because the field is encrypted we can't do any validation of its structure as the ticket originally stated; we'll have to rely on clients to do this validation instead.