[PM-23410] Feature: Allow loading auth tokens from external namespace#97
[PM-23410] Feature: Allow loading auth tokens from external namespace#97evanjarrett wants to merge 5 commits into
Conversation
…m outside the current bitwardensecret namespace
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
|
Any update on this? This feature is trivial for a clean & scalable setup. Replicating the secret for every namespace is hugely anti-pattern and insecure. |
I switched to External Secrets until this is implemented and stable. It works fantastic with External Secrets. |
|
Anyone looking at this @patrick-bitwarden @mandreko-bitwarden ??? This is a very important feature. |
|
This is great work, any word on when this will be merged? I'd love to start using this feature ASAP. |
|
Is there a time line when this PR get's merged? We are really waiting for this. |
|
@aj-bw what is the status of this PR.. ? |
|
For anyone wondering I ended up using reflector and it worked great. Wish this was a part of the repo already. |
🎟️ Tracking
#47
#94
📔 Objective
This implements an optional parameter
namespacein AuthToken that allows for fetching the token from an external namespace than the one the BitwardenSecret is currently in.In addition to this, I have made small changes to the GitHub Actions workflows so that they build, or are appropriately skipped on forked branches.
One of those was caused by adding the default permissions to the workflow as read. We need the GITHUB_SECRET to have
writepermissions in order to publish new packages to the org.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes