fix(doctor): improve shell path resolution#742
Open
kalvinnchau wants to merge 2 commits into
Open
Conversation
use shell path-only lookup commands instead of plain which and validate resolved candidates as absolute executable files. apply the same executable validation to shared cli resolvers so function or alias output cannot be treated as a binary path.
flatten login shell resolution branches and avoid an intermediate allocation when building lookup commands. preserve executable path validation while making output summarization safe for non-ascii command output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whichwith path-only shell lookup:whence -pfor zsh andtype -Pfor bash.acp-clientandblox-clicommand discovery.i have git mapped to a function that does some cleanup, but a minimal repro:
Testing
cargo fmt -p doctor -p acp-client -p blox-clicargo test -p doctor -p acp-client -p blox-cli