expose fractionalSecondDigits as a property of resolvedOptions()#5414
Merged
jedel1043 merged 1 commit intoJul 22, 2026
Merged
Conversation
github-actions
Bot
added
the
Waiting On Review
github-actions
Bot
added
C-Builtins
jedel1043
approved these changes
Jul 10, 2026
jedel1043
left a comment
jedel1043
left a comment
Member
There was a problem hiding this comment.
Looks good! Though you might need to run clippy on this, but preemptively approving.
Test262 conformance changes
Fixed tests (1):Tested main commit: |
camilojd
force-pushed
the
feat/expose-fractionalSecondDigits-in-resolvedOptions
branch
from
July 18, 2026 18:12
d158c9a to
b34729f
Compare
Contributor
Author
|
@jedel1043 Thanks for the review! I rebased, as I saw that the clippy failures came from outside the change, and they seem to be addressed now |
jedel1043
enabled auto-merge
July 21, 2026 23:36
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5414 +/- ##
===========================================
+ Coverage 47.24% 62.74% +15.50%
===========================================
Files 476 534 +58
Lines 46892 59079 +12187
===========================================
+ Hits 22154 37070 +14916
+ Misses 24738 22009 -2729 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-actions
Bot
removed
the
Waiting On Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi boa-devs!
I have a small contribution for the "ECMA-402" effort. Please let me know if this looks good to you.
It changes the following:
fractionalSecondDigitsas a property inside the object returned byresolvedOptions()