perf: use mimalloc as the global allocator on macOS#5431
Open
hansl wants to merge 1 commit into
Open
Conversation
The CLI's default `fast-allocator` feature only installed a fast allocator on x86_64 Linux (jemalloc) and Windows (mimalloc); macOS silently fell back to the system `libmalloc`. Extend the existing mimalloc arm to cover macOS in both the CLI and the benchmark harness (`mimalloc-safe` already supports Apple Silicon). Keeping the benchmarks on a fast allocator on macOS also stops local runs from measuring `libmalloc` overhead instead of engine work, so results track CI (Linux/jemalloc) far more closely. Measured locally, allocation-heavy workloads improve by up to ~8.6% (closures/create) versus libmalloc, while compute-bound benchmarks are unchanged.
github-actions
Bot
added
the
Waiting On Review
hansl
added
C-Benchmark
github-actions
Bot
added
the
C-Dependencies
Test262 conformance changes
Tested main commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI's default
fast-allocatorfeature only installed a fast allocator on x86_64 Linux (jemalloc) and Windows (mimalloc); macOS silently fell back to the systemlibmalloc. Extend the existing mimalloc arm to cover macOS in both the CLI and the benchmark harness (mimalloc-safealready supports Apple Silicon).Keeping the benchmarks on a fast allocator on macOS also stops local runs from measuring
libmallocoverhead instead of engine work, so results track CI (Linux/jemalloc) far more closely. Measured locally, allocation-heavy workloads improve by up to ~8.6% (closures/create) versus libmalloc, while compute-bound benchmarks are unchanged.