feat(skills): skill-builder scaffolds codex override-catalog entry (ag-cw2y item 4)#611
Merged
Merged
Conversation
…g-cw2y item 4)
A new skill previously tripped validate-codex-override-coverage ('source skill
missing from Codex catalog'), the 4th gate that cost /burndown #600 a CI round.
- scripts/append-codex-override-entry.sh: idempotent, JSON-aware helper that
appends a parity_only entry (name/treatment/wave=catalog-parity/reason) to
skills-codex-overrides/catalog.json if the skill is absent. parity_only is the
default for skill-builder's canonical-derived codex form; author flips to
bespoke + scaffolds the override dir if a Codex-only divergence is needed.
Repo-root-injectable for testing.
- init.sh: calls it in the new-skill plumbing block alongside the dispositions
row (#609/#610) and --fix-counts (#610).
Codex artifact: refreshed skill-builder source/generated hash only (6 unrelated
pre-existing main drifts left untouched). PR-scope codex validation passes.
Closes-scenario: ag-cw2y#override-catalog-scaffold
Bounded-context: BC4-factory
Evidence: tests/scripts/append-codex-override-entry.bats
boshu2
added a commit
that referenced
this pull request
May 30, 2026
…egate (ag-vzbt) (#612) ## What **ag-vzbt** — the last `ag-cw2y` item. The skills-codex description catalog budget was a **hard aggregate** (2800 chars, bumped 2600→2700→2800 as skills landed) with ~17 chars headroom. Adding the Nth+ skill walls out — `/burndown` #600 was forced into a 17-char stub ("Bounded epic loop") to fit. ## How Replace the hard aggregate with a **per-skill average** cap (`CODEX_DESC_AVG_FAIL_CHARS=45`) that scales with the catalog: - Each terse description keeps the average low; the gate fails only if descriptions are **bloated on average** — not because the catalog grew. - Current state: avg **35** chars/skill (77% of 45) — real headroom, and it never becomes a wall again. - The per-skill hard cap (`DESC_FAIL_CHARS=180`) still bounds any single bloated description. - `BUDGET_REPO_ROOT` override added so the rule is fixture-testable. ## Tests (TDD, red→green) `tests/scripts/codex-desc-avg-budget.bats` — PASS under budget / FAIL over budget / **100 skills (total ~3800 > old 2800 wall) still pass** because avg stays low. 3/3 green; shellcheck clean; real-repo gate passes (avg 35/45). ##⚠️ Pre-existing unrelated red The local fast gate also surfaces a **pre-existing** `mkdocs strict` failure on `rfcs/0001-finding-generator-parallelism.md` — reproduces on clean `origin/main` with my changes stashed; my diff touches only the test script + bats (zero docs). Flagging separately; not in scope here. ## ag-cw2y status **All four items now done** (items 1,2,4 merged #609/#610/#611; item 3 here). A brand-new skill is now **one-shot-green** → this unblocks **`ag-hdqu0.8`** (last Outcomes bead) and **`/burndown` #600**. Closes-scenario: ag-vzbt#per-skill-average-budget Bounded-context: BC2-validation Evidence: tests/scripts/codex-desc-avg-budget.bats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ag-cw2y item 4 — the 4th and last new-skill gate that cost
/burndown#600 a CI round. A new skill previously trippedvalidate-codex-override-coverage("source skill missing from Codex catalog"). skill-builder now adds the catalog entry automatically.How
scripts/append-codex-override-entry.sh— idempotent, JSON-aware: appends aparity_onlyentry (name/treatment/wave=catalog-parity/reason) toskills-codex-overrides/catalog.jsonif the skill is absent.parity_onlyis correct for skill-builder's canonical-derived codex form; author flips tobespoke+ scaffolds the override dir only if a Codex-only divergence is needed. Repo-root-injectable.init.sh— calls it in the new-skill plumbing block alongside the dispositions row (feat(skills): heal --strict checks skill-dispositions coverage (ag-cw2y item 1) #609/feat(skills): skill-builder scaffolds dispositions row + narrative counts (ag-cw2y items 1-scaffold + 2) #610) and--fix-counts(feat(skills): skill-builder scaffolds dispositions row + narrative counts (ag-cw2y items 1-scaffold + 2) #610). All three gates now pre-empted at scaffold time.Tests (TDD, red→green)
tests/scripts/append-codex-override-entry.bats— appends parity_only / stays valid JSON / idempotent / no-dup-on-existing. 4/4 green. shellcheck clean.Codex artifact
Refreshed only skill-builder's hash (6 unrelated pre-existing
maindrifts untouched). PR-scope codex validation passes.ag-cw2y status after this
Item 1 (#609 check + #610 scaffold) ✅ · Item 2 (#610) ✅ · Item 4 (here) ✅ · Item 3 (codex desc token budget /
ag-vzbt) is the only remaining piece. Once item 3 lands, a new skill — and thereforeag-hdqu0.8+/burndown#600 — is fully one-shot-green.Closes-scenario: ag-cw2y#override-catalog-scaffold
Bounded-context: BC4-factory
Evidence: tests/scripts/append-codex-override-entry.bats