fix: add protections against dataraces in socket engines, cluster timer and queues.#1587
Open
fclivaz42 wants to merge 1 commit into
Open
fix: add protections against dataraces in socket engines, cluster timer and queues.#1587fclivaz42 wants to merge 1 commit into
fclivaz42 wants to merge 1 commit into
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
My simple echo bots are stuck in epoll even with 10.1.5 version. |
Author
You could try to test run by applying this PR as a patch and compile/install the library then test it. Feedback would actually be very welcome! |
Contributor
|
are you saying a simple test bot now gets stuck in epoll and didn't before 10.1.5? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, here is a smaller PR with less risky changes.
I have changed the following:
epoll, where I removed an unused variable and added a lock where elements were removed from the fds vectorkqueue, where I have added a lock similar toepollqueues, where I have changed two booleans tostd::atomicbooleans, added a safeguard for theclivariable and guards for theremovalsvector.timer, where I added a guard to an unguarded if statement.I believe these changes are light enough to not cause any issues whatsoever, and have kept the riskier changes out of this PR for now while I do more testing on my end.
Code change checklist