Skip to content

fix: line rendering with ImGui v1.93+ #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brenocq wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −0
Open

fix: line rendering with ImGui v1.93+ #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions implot3d_items.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,26 @@
} while (0)

IMPLOT3D_INLINE void GetLineRenderProps(const ImDrawList3D& draw_list_3d, float& half_weight, ImVec2& tex_uv0, ImVec2& tex_uv1) {
#if IMGUI_VERSION_NUM >= 19299 || defined(IM_DRAWLIST_TEX_LINES_SAMPLE_COUNT)
// ImGui 1.93+ bakes anti-aliased line textures with a new layout and picks them via ImDrawList::_SelectLineTexture().
// ImDrawList3D is not an ImDrawList, so we inline the same texture/fringe selection here (assuming _FringeScale == 1).
const float screen_thickness = half_weight * 2.0f; // callers clamp weight to >= 1, so screen_thickness >= 1
if (ImPlot3D::ImHasFlag(draw_list_3d._Flags, ImDrawFlags_AALines)) {
int texture_idx;
if (screen_thickness <= IM_DRAWLIST_TEX_LINES_DETAILED_WIDTH)
texture_idx = (int)((screen_thickness - 1.0f) * IM_DRAWLIST_TEX_LINES_SAMPLE_COUNT + 0.5f) + (IM_DRAWLIST_TEX_LINES_WIDTH_MAX + 1);
else if (screen_thickness < (float)IM_DRAWLIST_TEX_LINES_WIDTH_MAX - 1.5f)
texture_idx = (int)(screen_thickness + 0.5f);
else
texture_idx = IM_DRAWLIST_TEX_LINES_WIDTH_MAX - 1;
const ImVec4 tex_uvs = draw_list_3d._SharedData->TexUvLines[texture_idx]; // (u0, u1, v, 1/thickness)
tex_uv0 = ImVec2(tex_uvs.x, tex_uvs.z);
tex_uv1 = ImVec2(tex_uvs.y, tex_uvs.z);
half_weight += 0.5f * screen_thickness * tex_uvs.w; // add half of the anti-aliasing fringe
} else {
tex_uv0 = tex_uv1 = draw_list_3d._SharedData->TexUvWhitePixel;
}
#else
const bool aa = ImPlot3D::ImHasFlag(draw_list_3d._Flags, ImDrawListFlags_AntiAliasedLines) &&
ImPlot3D::ImHasFlag(draw_list_3d._Flags, ImDrawListFlags_AntiAliasedLinesUseTex);
if (aa) {
Expand All @@ -90,6 +110,7 @@ IMPLOT3D_INLINE void GetLineRenderProps(const ImDrawList3D& draw_list_3d, float&
} else {
tex_uv0 = tex_uv1 = draw_list_3d._SharedData->TexUvWhitePixel;
}
#endif
}

//-----------------------------------------------------------------------------
Expand Down
Loading