Skip to content

Fix incorrect dht query behavior#1101

Open
Rexagon wants to merge 4 commits into
masterfrom
fix/overlay-peer-discovery
Open

Fix incorrect dht query behavior#1101
Rexagon wants to merge 4 commits into
masterfrom
fix/overlay-peer-discovery

Conversation

@Rexagon

@Rexagon Rexagon commented Jun 18, 2026

Copy link
Copy Markdown
Member

This PR fixes some bugs in DHT queries which caused a random freezing at the node startup.

  • Fixed event data race when adding new overlays;
  • Make peer resolver to finish early on event while waiting for backoff interval;
  • Rework query candidates scheduling.

@Rexagon Rexagon requested review from 0xdeafbeef and Mododo June 18, 2026 16:40
@github-actions

Copy link
Copy Markdown

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1101

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1101
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1101 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.35683% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.34%. Comparing base (88996d8) to head (f0a4033).

Files with missing lines Patch % Lines
network/src/dht/query.rs 97.42% 3 Missing and 2 partials ⚠️
network/src/dht/peer_resolver.rs 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1101      +/-   ##
==========================================
+ Coverage   60.22%   60.34%   +0.11%     
==========================================
  Files         473      473              
  Lines       80541    80675     +134     
  Branches    80541    80675     +134     
==========================================
+ Hits        48507    48680     +173     
+ Misses      29712    29666      -46     
- Partials     2322     2329       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants