Fix SDL window and resource destruction calls - #1410
Merged
Merged
Conversation
Owner
|
"Calling SDL's window setters should always divide by pixel density but currently set position multiples it instead." I don't think it does? - let internal trySetWindowSize (size : Vector2i) state =
match Option.flatten (Option.map SdlDeps.getWindowOpt state.SdlDepsOpt) with
| Some window ->
let pixelDensity = SDL3.SDL_GetWindowPixelDensity window
SDL3.SDL_SetWindowSize (window, int (single size.X / pixelDensity), int (single size.Y / pixelDensity)) |> ignore
| None -> () |
Collaborator
Author
|
@bryanedds You're looking at "set window size" not "set window position". |
Owner
|
Ah I see. I'll apply the trySetWindowPosition fix manually for now then come back to this PR when I have time to review it properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #1392