Skip to content

[bug]: Incorrect comments for deploymentChecker.HasStarted in blockchain/versionbits.go #2581

Open
#2602
Open
[bug]: Incorrect comments for deploymentChecker.HasStarted in blockchain/versionbits.go#2581
#2602
Labels
bug

Description

@ghost
ghost
opened on Jul 25, 2026

Background

The comments above deploymentChecker.HasStarted in blockchain/versionbits.go appear to have been copied from HasEnded and do not match the implementation.

btcd/blockchain/versionbits.go

Lines 156 to 163 in 05585e0

// HasEnded returns true if the target consensus rule change has expired
// or timed out (at the next window).
//
// This implementation returns the value defined by the specific deployment the
// checker is associated with.
//
// This is part of the thresholdConditionChecker interface implementation.
func (c deploymentChecker) HasStarted(blkNode *blockNode) bool {

Activity

  1. ghost added
    bug
    on Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions