rpcserver: test null getblock verbosity - #2605
Open
Roasbeef wants to merge 1 commit into
Open
Conversation
In this commit, we add an RPC integration test for an explicit null getblock verbosity parameter. The request must use the documented default verbosity, return the verbose block result, and keep the WebSocket client connected. This covers the panic fixed in #2600 through the same raw JSON-RPC decoding path that exposed it.
Coverage Report for CI Build 34551838430Coverage decreased (-0.02%) to 54.006%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions22 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we add the missing end-to-end regression test for #2597 and the fix merged in #2600. The test sends
getblockthroughRawRequestwith an explicit JSONnullverbosity, then verifies that btcd applies the default verbose response rather than disconnecting the WebSocket client.The same test fails on #2600 parent with
websocket: close 1006 unexpected EOFandthe client has been disconnected, and passes on currentmaster.Testing
make unitgolangci-lint run --timeout=5m --new-from-rev=a3f203843