Don't count all rows when using pagination#228
Merged
Conversation
This was referenced Apr 21, 2026
Merged
Merged
isakstenstrom
force-pushed
the
pagination-count-fix
branch
from
e76f720 to
7866ca4
Compare
meroton-benjamin
approved these changes
May 4, 2026
Ent counts all rows in the table when using pagination, even when it doesn't need to.
isakstenstrom
force-pushed
the
pagination-count-fix
branch
from
7866ca4 to
13026fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is a stacked PR. Please merge #226, #227 first.
Sometimes when calling paginate, Ent needs to do a
SELECT COUNT("id")on all rows in a table, but sometimes it does it even when it is not needed. This PR overrides one of the templates Ent uses to generate the pagination function, removing the unnecessary count. For large tables this can be a sizable performance savings.This should be fixed when ent/contrib#625 is merged.