feat: honour Retry-After for artifact retries#3737
Draft
lox wants to merge 1 commit into
Draft
Conversation
moskyb
approved these changes
Mar 5, 2026
moskyb
left a comment
Contributor
There was a problem hiding this comment.
looks good! good to bring this in line with many of our other retry loops.
Contributor
|
Hi @lox, just wondering what the state is here. It's draft, but it's been approved - time to take it out of draft and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follow-up teaches artifact retry loops to honour server-provided
Retry-Afterheaders, so retry pacing can be coordinated by the backend during pressure events.What Changed
internal/artifact/retry_after.goto parse and applyRetry-Aftervalues to retry intervals.Retry-Afterhandling intoCreateArtifactsretries ininternal/artifact/batch_creator.go.Retry-Afterhandling intoUpdateArtifactsretries ininternal/artifact/uploader.go.internal/artifact/batching_test.gofor valid and invalidRetry-Afterbehaviour.Why
Retry-Afteris absent or invalid.Validation
go tool gofumpt -extra -w internal/artifact/retry_after.go internal/artifact/batch_creator.go internal/artifact/uploader.go internal/artifact/batching_test.gogo test ./internal/artifact -count=1go test ./api ./agent ./clicommand -count=1Notes