Skip to content

7.0: CompareAndSwapInterface and race condition fixes in atomic operations - #24

Open
byjg wants to merge 8 commits into
masterfrom
7.0
Open

7.0: CompareAndSwapInterface and race condition fixes in atomic operations#24
byjg wants to merge 8 commits into
masterfrom
7.0

Move Psalm to a dedicated tools/psalm manifest

8b5a82a
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Psalm succeeded Aug 22, 2026 in 3s

47 new alerts

New alerts in code changed by this pull request

  • 47 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 237 in src/Psr16/FileSystemCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

RiskyTruthyFalsyComparison Note

Operand of type false|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.

Check notice on line 287 in src/Psr16/FileSystemCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

MissingClosureReturnType Note

Closure does not have a return type, expecting mixed

Check notice on line 287 in src/Psr16/FileSystemCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

MissingClosureParamType Note

Parameter $currentValue has no provided type

Check notice on line 287 in src/Psr16/FileSystemCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

MissingClosureParamType Note

Parameter $value has no provided type

Check notice on line 295 in src/Psr16/FileSystemCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

MissingClosureReturnType Note

Closure does not have a return type, expecting mixed

Check notice on line 295 in src/Psr16/FileSystemCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

MissingClosureParamType Note

Parameter $currentValue has no provided type

Check notice on line 295 in src/Psr16/FileSystemCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

MissingClosureParamType Note

Parameter $value has no provided type

Check notice on line 303 in src/Psr16/FileSystemCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

MissingClosureParamType Note

Parameter $currentValue has no provided type

Check notice on line 303 in src/Psr16/FileSystemCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

MissingClosureParamType Note

Parameter $value has no provided type

Check notice on line 16 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PropertyNotSetInConstructor Note

Property ByJG\Cache\Psr16\MemcachedEngine::$container is not defined in constructor of ByJG\Cache\Psr16\MemcachedEngine or in any methods called in the constructor

Check notice on line 16 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

ClassMustBeFinal Note

Class ByJG\Cache\Psr16\MemcachedEngine is never extended and is not part of the public API, and thus must be made final.

Check notice on line 22 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

MissingClassConstType Note

Class constant "ByJG\Cache\Psr16\MemcachedEngine::EXPIRE_NOW" should have a declared type.

Check notice on line 243 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method increment on possibly null value

Check notice on line 266 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method decrement on possibly null value

Check notice on line 288 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method add on possibly null value

Check notice on line 288 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyInvalidArgument Note

Argument 3 of Memcached::add expects int, but possibly different type DateInterval|int provided

Check notice on line 312 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyInvalidArgument Note

Argument 3 of Memcached::add expects int, but possibly different type DateInterval|int provided

Check notice on line 326 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyInvalidArgument Note

Argument 4 of Memcached::cas expects int, but possibly different type DateInterval|int provided

Check notice on line 340 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method add on possibly null value

Check notice on line 340 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyInvalidArgument Note

Argument 3 of Memcached::add expects int, but possibly different type DateInterval|int provided

Check notice on line 356 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyInvalidArgument Note

Argument 3 of ByJG\Cache\Psr16\MemcachedEngine::casIfEquals expects int, but possibly different type DateInterval|int provided

Check notice on line 371 in src/Psr16/MemcachedEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method get on possibly null value

Check notice on line 17 in src/Psr16/RedisCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

PropertyNotSetInConstructor Note

Property ByJG\Cache\Psr16\RedisCacheEngine::$container is not defined in constructor of ByJG\Cache\Psr16\RedisCacheEngine or in any methods called in the constructor

Check notice on line 17 in src/Psr16/RedisCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

ClassMustBeFinal Note

Class ByJG\Cache\Psr16\RedisCacheEngine is never extended and is not part of the public API, and thus must be made final.

Check notice on line 30 in src/Psr16/RedisCacheEngine.php

See this annotation in the file changed.

Code scanning / Psalm

MissingClassConstType Note

Class constant "ByJG\Cache\Psr16\RedisCacheEngine::LUA_INCREMENT_BY" should have a declared type.