[19.0][PATCH] contract_sale#14
Open
Copilot wants to merge 36 commits into
Open
Conversation
* README by fragments * Adjusted dependency * Changed root menu XML-ID
[REF] Contract Sale: update translations
The lowest model access for contract.contract model is group_account_invoice group. However the addon adds two smart buttons to res.partner view without any security restrictions and without compute_sudo attribute on computed fields. This causes the view to crash when a user without the proper permissions tries to access the res.partner form view. The solution adds groups_id to the partner form views in which the buttons are added, so the only loads when the user has proper permissions. Other way to solve it would be to add compute_sudo attribute to the relevant fields, but this causes an access error when the user clicks on the smart buttons.
Currently translated at 100.0% (1 of 1 strings) Translation: contract-12.0/contract-12.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale/es_CL/
…ce: from contract_sale to contract
[BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract_sale/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-18.0/contract-18.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract_sale/
Copilot created this pull request from a session on behalf of
CRogos
May 29, 2026 15:07
View session
60676c4 to
0583a8a
Compare
Copilot
AI
changed the title
[MIG] contract_sale: Migration to 19.0
[FIX] contract_sale: rename groups_id to group_ids for Odoo 19.0
May 29, 2026
f0f99d6 to
223f527
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI tests fail with
ValueError: Invalid field 'groups_id' in 'res.users'because Odoo 19.0 renamedgroups_id→group_idsonres.users.contract_sale/tests/test_sale_contract.pyto usegroup_ids(2 occurrences in user creation)