Skip to content

[19.0][PATCH] contract_sale#14

Open
Copilot wants to merge 36 commits into
19.0from
copilot/odoo-migration-contract-sale-18-to-19
Open

[19.0][PATCH] contract_sale#14
Copilot wants to merge 36 commits into
19.0from
copilot/odoo-migration-contract-sale-18-to-19

Conversation

Copy link
Copy Markdown

Copilot AI commented May 29, 2026

CI tests fail with ValueError: Invalid field 'groups_id' in 'res.users' because Odoo 19.0 renamed groups_idgroup_ids on res.users.

  • Updated contract_sale/tests/test_sale_contract.py to use group_ids (2 occurrences in user creation)
# Before (18.0)
"groups_id": [Command.set(...)]

# After (19.0)
"group_ids": [Command.set(...)]

Luis M. Ontalba and others added 30 commits May 29, 2026 15:01
* README by fragments
* Adjusted dependency
* Changed root menu XML-ID
[REF] Contract Sale: update translations
The lowest model access for contract.contract model is group_account_invoice group. However the addon adds two smart buttons to res.partner view without any security restrictions and without compute_sudo attribute on computed fields.
This causes the view to crash when a user without the proper permissions tries to access the res.partner form view.
The solution adds groups_id to the partner form views in which the buttons are added, so the only loads when the user has proper permissions.
Other way to solve it would be to add compute_sudo attribute to the relevant fields, but this causes an access error when the user clicks on the smart buttons.
Currently translated at 100.0% (1 of 1 strings)

Translation: contract-12.0/contract-12.0-contract_sale
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale/es_CL/
[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-17.0/contract-17.0-contract_sale
Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract_sale/
oca-ci and others added 4 commits May 29, 2026 15:01
Copilot finished work on behalf of CRogos May 29, 2026 15:07
Copilot AI requested a review from CRogos May 29, 2026 15:07
@CRogos CRogos force-pushed the copilot/odoo-migration-contract-sale-18-to-19 branch from 60676c4 to 0583a8a Compare May 29, 2026 15:14
Copilot AI changed the title [MIG] contract_sale: Migration to 19.0 [FIX] contract_sale: rename groups_id to group_ids for Odoo 19.0 May 29, 2026
Copilot finished work on behalf of CRogos May 29, 2026 15:34
@CRogos CRogos force-pushed the copilot/odoo-migration-contract-sale-18-to-19 branch from f0f99d6 to 223f527 Compare May 29, 2026 15:54
@CRogos CRogos marked this pull request as ready for review May 29, 2026 15:55
@CRogos CRogos changed the title [FIX] contract_sale: rename groups_id to group_ids for Odoo 19.0 [19.0][PATCH] contract_sale May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.