fix(tasks): reuse running process manager for process deps - #3152
Open
Arshgill01 wants to merge 1 commit into
Open
Arshgill01 wants to merge 1 commit into
Arshgill01 wants to merge 1 commit into
Conversation
Contributor
🔍 Suggested ReviewersBased on git blame analysis of the changed lines, the following contributors have significant experience with the modified code:
Please consider reviewing this PR as you have authored significant portions of the code being modified. Your expertise would be valuable! 🙏 This comment was automatically generated by git-blame-auto-reviewer Last updated: 2026-09-14T04:35:45.926Z |
4 tasks
Arshgill01
marked this pull request as ready for review
September 3, 2026 04:04
5 tasks
cursor
Bot
force-pushed
the
cursor/fix-tasks-process-deps-b815
branch
3 times, most recently
from
September 7, 2026 04:44
2e095b4 to
cdf7fc7
Compare
Contributor
Author
cursor
Bot
force-pushed
the
cursor/fix-tasks-process-deps-b815
branch
2 times, most recently
from
September 10, 2026 03:51
d7b3766 to
4ae8f6d
Compare
devenv tasks run used to start devenv:processes:* dependencies in a fresh local runner even when devenv up already had a manager. That crash-looped healthy services such as postgres. When a manager is already running, attach to it, start only missing process deps, wait until they are ready, and skip launching or stopping those processes in the local runner. Fixes cachix#3137 Co-authored-by: Arshdeep singh <arshgill6120@gmail.com>
cursor
Bot
force-pushed
the
cursor/fix-tasks-process-deps-b815
branch
from
September 14, 2026 04:35
4ae8f6d to
f1f9546
Compare
Contributor
Author
|
Rebased this branch onto latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3137.
devenv tasks runstarteddevenv:processes:*dependencies in a fresh local runner even when those processes were already healthy underdevenv up. That second copy crash-looped services such as PostgreSQL (initdbas root).When a process manager is already running,
tasks runnow:Start/start_with_depsskips Ready/Starting/Waiting)ignore_process_depsso the local runner does not launch them againstop_allon exit, so the existing manager keeps ownershipIf no manager is running, behavior is unchanged: process deps start locally and are stopped when the task graph finishes.
Test plan
cargo test -p devenv-tasks --lib scheduled_process_namescargo fmt --all -- --checktests/tasks-run-attach-running(devenv up -dthendevenv tasks run test:repromust keep the dummy process pid andstarts == 1)services.postgres.enable = trueandafter = ["devenv:processes:postgres"], rundevenv up -d; devenv tasks run test:reprowithout a postgres crash loop