Repository navigation
Retry failed Spot jobs on standard capacity without restarting cancelled jobs - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Resubmit failed Spot jobs once on standard capacity after Batch retries are exhausted. Preserve
CANCELLEDstatus so explicitly cancelled jobs are never resubmitted by this fallback.Add regression coverage for fallback success, fallback failure, and cancellation with both failure-reporting settings. Let SNP fold tests inherit the current environment.
Related issue
None.
Type of change
(If applicable) How has this been tested?
PYTHONPATH=src python -m pytest src/tests/test_gcprunner.py -q: 77 passed, 3 skipped. Cancellation regressions failed before the status-mapping fix and passed afterward.git diff --checkpassed. SNP fold tests were not run.