Skip to content

fix: increase retry period for validate_profile_deployments_with_custom_images #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvlassis wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

fix: increase retry period for validate_profile_deployments_with_custom_images #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
411648e
fix: increase retry period for validate_profile_deployments_with_cust…
mvlassis Jun 25, 2026
890c3fa
Update tests
mvlassis Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion charms/kfp-profile-controller/tests/integration/test_charm_ambient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,9 +326,11 @@ def validate_profile_resources(
assert expected_label_value == namespace.metadata.labels[expected_label]


# Retry for 90 seconds since the metacontroller's `resyncPeriodSeconds` is
# currently 60s, so at worst it will take 60s for the resync to be triggered.
@retry(
wait=wait_exponential(multiplier=1, min=1, max=10),
stop=stop_after_delay(60),
stop=stop_after_delay(90),
reraise=True,
)
def validate_profile_deployments_with_custom_images(
Expand Down
4 changes: 3 additions & 1 deletion charms/kfp-profile-controller/tests/integration/test_charm_object_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,11 @@ def validate_profile_resources(
assert expected_label_value == namespace.metadata.labels[expected_label]


# Retry for 90 seconds since the metacontroller's `resyncPeriodSeconds` is
# currently 60s, so at worst it will take 60s for the resync to be triggered.
@retry(
wait=wait_exponential(multiplier=1, min=1, max=10),
stop=stop_after_delay(60),
stop=stop_after_delay(90),
reraise=True,
)
def validate_profile_deployments_with_custom_images(
Expand Down
4 changes: 3 additions & 1 deletion charms/kfp-profile-controller/tests/integration/test_charm_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,9 +321,11 @@ def validate_profile_resources(
assert expected_label_value == namespace.metadata.labels[expected_label]


# Retry for 90 seconds since the metacontroller's `resyncPeriodSeconds` is
# currently 60s, so at worst it will take 60s for the resync to be triggered.
@retry(
wait=wait_exponential(multiplier=1, min=1, max=10),
stop=stop_after_delay(60),
stop=stop_after_delay(90),
reraise=True,
)
def validate_profile_deployments_with_custom_images(
Expand Down
Loading