CIP-0116? | Universal JSON Encoding for Domain Types#766
Merged
rphair merged 64 commits intoMay 14, 2024
Conversation
…rammatic processing
- New types: TransactionWitnessSet, MIR, BootstrapWitness, etc
Ryun1
added
Category: Wallets
Ryun1
reviewed
Feb 22, 2024
Ryun1
left a comment
Ryun1
left a comment
Collaborator
There was a problem hiding this comment.
A really great proposal 💪
See, my mainly housekeeping comments.
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
|
Awesome |
Ryun1
reviewed
Feb 22, 2024
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
68 tasks
Ryun1
reviewed
May 3, 2024
| "format": "hex", | ||
| "pattern": "^[0-9a-f]{64}$", | ||
| "maxLength": 64, | ||
| "minLength": 64 |
Collaborator
There was a problem hiding this comment.
Why do we specify minLength for transaction hashes but not other things, such as keyHashes or addresses?
Ryun1
reviewed
May 3, 2024
Ryun1
reviewed
May 3, 2024
Ryun1
reviewed
May 3, 2024
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
Ryun1
reviewed
May 3, 2024
Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>
CIP-116 | Add feedback from query layer standardisation workshop #2
Ryun1
approved these changes
May 3, 2024
rphair
added
the
State: Last Check
rphair
approved these changes
May 4, 2024
rphair
left a comment
rphair
left a comment
Collaborator
There was a problem hiding this comment.
Likewise I am more than satisfied by the rounds of review & response: marked Last Check to keep attention on it until merging when fully ready (re: Implementation Plan).
rphair
removed
the
State: Last Check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a CIP corresponding to CPS-11.
It includes a json-schema file specifying JSON layout for Babbage-era Cardano domain types.
The markdown file contains motivation for encoding choices and proposed conventions for building schemas for future eras.
(Rendered version)