Skip to content

Preserve EXTRA_ARGS boundaries in CMake discovery - #3247

Draft
17kaushalsingh wants to merge 1 commit into
catchorg:develfrom
17kaushalsingh:fix/3239-extra-args
Draft

17kaushalsingh wants to merge 1 commit into
catchorg:develfrom
17kaushalsingh:fix/3239-extra-args

Conversation

@17kaushalsingh

Copy link
Copy Markdown

Description

Expand EXTRA_ARGS as separate arguments when preparing CTest commands. Previously, EXTRA_ARGS --colour-mode none became one semicolon-separated argument and failed parsing. The discovery fixture now checks multiple options and a value containing spaces.

This overlaps with #3240 by @CyberKun and uses the same list-expansion fix. Submitted as a draft for visibility; the existing PR may be preferred. This version has been validated with the compiled integration fixture locally.

Validation

  • Verified all 22 CTest registrations and TEST_LIST entries, including exact extra-argument boundaries.
  • Executed all 22 discovered tests successfully on macOS with CMake 4.4.3.
  • PrepareCommandFragment and DecomposeJsonArray helper tests passed.
  • git diff --check passed.

GitHub Issues

Closes #3239.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

catch_discover_tests passes all EXTRA_ARGS as one argument

1 participant