Repository navigation
Preserve EXTRA_ARGS boundaries in CMake discovery - #3247
Draft
17kaushalsingh wants to merge 1 commit into
Draft
17kaushalsingh wants to merge 1 commit into
17kaushalsingh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expand EXTRA_ARGS as separate arguments when preparing CTest commands. Previously,
EXTRA_ARGS --colour-mode nonebecame one semicolon-separated argument and failed parsing. The discovery fixture now checks multiple options and a value containing spaces.This overlaps with #3240 by @CyberKun and uses the same list-expansion fix. Submitted as a draft for visibility; the existing PR may be preferred. This version has been validated with the compiled integration fixture locally.
Validation
GitHub Issues
Closes #3239.