Repository navigation
Escape control bytes with --invisibles - #3249
Open
wozhenbang2004 wants to merge 4 commits into
Open
wozhenbang2004 wants to merge 4 commits into
wozhenbang2004 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--invisiblesstill writes NUL, BEL, ESC and other control bytes directly into string comparison failures. Depending on the terminal, strings that differ only in these bytes can look identical.Escape ASCII control bytes when this option is enabled, using short escapes where available and
\xNNfor the rest. Default output and non-ASCII bytes stay unchanged. The CLI help and documentation now describe the expanded behavior.The new stringification cases fail before the change, and all 82 CTest tests from the
basic-testspreset pass. A real test executable now prints"abc\0" == "abc"with--invisibles; its output without the flag is byte-identical to the original version.GitHub Issues
Closes #1928.