Skip to content

Fix lazy series logging regression test - #245

Merged
cbyrohl merged 1 commit into
mainfrom
fix-series-logging-test
Sep 20, 2026
Merged

cbyrohl merged 1 commit into
mainfrom
fix-series-logging-test

Conversation

@cbyrohl

@cbyrohl cbyrohl commented Sep 20, 2026

Copy link
Copy Markdown
Owner

The weekly regression job fails both test_areposimulation_lazy_message cases because the test still captures stdout after #241 moved the cache message to scida.series logging. Capture that logger at INFO with pytest's caplog fixture and check the captured log text while retaining the lazy-initialization assertion.

Validation in the fix worktree: SCIDA_TESTDATA_SILENT_UNAVAILABLE=FALSE uv run --active --no-sync python -m pytest tests/external/test_series.py -k areposimulation_lazy_message -v -rs completed with 1 passed, 1 skipped, and 9 deselected. TNGvariation_simulation passed; the full TNG50-4 series is unavailable locally, so its case still needs validation on the regression runner. The check reused the existing Python 3.11 environment with the worktree's src on PYTHONPATH.

Failing CI run: https://github.com/cbyrohl/scida/actions/runs/35500236318

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-20T16:41:58.533904Z cae9ac4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cbyrohl
cbyrohl merged commit b1686b2 into main Sep 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant