rbac-proxy - #172
Open
shruthi713 wants to merge 4 commits into
Open
Conversation
- Added TaskManagerSpec (embeds CDAPServiceSpec for 1 replica constraint) to CDAPMasterSpec. - Generated DeepCopy and OpenAPI schema for TaskManager CRD. - Configured maxDescLen=0 for controller-gen to reduce ETCD request size below 1.5MB limits. - Configured deployment plans and constants to deploy TaskManager container via TaskManagerMain. - Updated utils and deployment generation tests and testdata fixtures to verify.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for a new optional CDAP service, the Task Manager (Netty Proxy). It adds the TaskManagerSpec to the API, updates the deployment plan, constants, and tests, and includes a sample deployment JSON. A review comment points out a duplicate return statement in controllers/deployment.go that should be removed.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.