Rename webauthn_id in README examples to avoid ambiguity#502
Open
ttanimichi wants to merge 1 commit into
Open
Conversation
ttanimichi
changed the title
webauthn_id in README examples to avoid ambiguity
ttanimichi
changed the title
webauthn_id in README examples to avoid ambiguitywebauthn_id in README examples to avoid ambiguity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README examples used the same name
webauthn_idfor two distinct concepts: the User Handle stored on the user, and the Credential ID stored on each credential. Using one name for both is confusing, so this PR renames them in the example code:user.webauthn_id→user.webauthn_user_handlecredential.webauthn_id→credential.credential_iduser.credentials→user.webauthn_credentials