refactor(traits): migrate Kem error types to associated types - #1552
Open
Arul-Sujith wants to merge 1 commit into
Open
refactor(traits): migrate Kem error types to associated types#1552Arul-Sujith wants to merge 1 commit into
Arul-Sujith wants to merge 1 commit into
Conversation
This commit addresses issue celabshq#1535 by changing the hard-coded KeyGenError, EncapsError, and DecapsError in the various Kem traits into associated types. This allows infallible implementations, such as ML-KEM, to specify core::convert::Infallible as their error type, removing the need for callers to handle impossible errors. Implementations for P-256 and Curve25519 have been updated accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Kem trait errors to use associated types #1535
Changes
libcrux_traits::kem(arrayref,slice, andowned).libcrux-ml-kemto specifycore::convert::Infallibleas its error type.libcrux-kemwrapper to take advantage of ML-KEM's infallibility, unwrapping it gracefully.curve25519andp256implementations to bind their associated types back to the standard library errors.