Repository navigation
refactor(sync)!: remove --direct-merge - #31
Merged
Merged
Conversation
`cella sync --direct-merge` turned on GitHub auto-merge for the sync PR, so it squash-merged itself once required checks passed. A sync PR deserves a human look before it lands: drift triage and migration notes can leave work that still passes the checks. The ship run now always stops at an open PR. The flag, the `directMerge` config field, `enableAutoMerge` and the `auto` option of the `gh pr merge` argv builder are gone. Merging an older open sync PR before a new sync starts still uses an immediate `gh pr merge --squash`. BREAKING CHANGE: `cella sync --direct-merge` is no longer accepted. Merge the sync PR by hand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cella sync --direct-mergeturned on GitHub auto-merge for the sync PR, so it squash-merged itself once required checks passed. A sync PR deserves a human look before it lands: drift triage and cella migration notes can leave work that still passes the checks. The ship run now always stops at an open PR.Removed: the
--direct-mergeflag and its help example, thedirectMergeconfig field,enableAutoMergein the sync service, and theautooption of thegh pr mergeargv builder, with their tests.Kept: merging an older open sync PR before a new sync starts still runs an immediate
gh pr merge --squash --delete-branch. That is a merge you confirm, not GitHub auto-merge.Breaking:
cella sync --direct-mergenow fails as an unknown option.Checks:
pnpm ts,pnpm lint,pnpm test(203 passed).🤖 Generated with Claude Code