Skip to content

New: Added support for new Vanilla button color mixins (fixes #32) - #33

Merged
oliverfoster merged 3 commits into
masterfrom
issue/32
Jun 24, 2025
Merged

New: Added support for new Vanilla button color mixins (fixes #32)#33
oliverfoster merged 3 commits into
masterfrom
issue/32

Conversation

@kirsty-hames

@kirsty-hames kirsty-hames commented Feb 12, 2025

Copy link
Copy Markdown
Contributor

Fixes #32

New

  • Added support for new Vanilla button color mixins PR. Default button style set to filled to mimic current Vanilla and outline as optional style. The implementation allows for additional styles to be created for custom themes.
  • Focus state added.
  • Legacy support added to prevent breaking change.
  • Button selector classes extended to prevent Vanilla styles overwriting (generic .btn-text and .btn-icon styles in Vanilla button.less). Same issue applies to Hint master, this wasn't introduced during this PR.

Testing legacy support

  1. Install Vanilla master.
  2. There should be no change in styling. Legacy styles apply.

Testing new Vanilla buttons

  1. Install Vanilla PR.
  2. Hint button style can be changed via the @item-ui-color-style variable in less/_defaults/_btn-style.less. Test both filled and outline styles.
  3. Check all states styles apply (default, hover and focus).

@kirsty-hames
support added for Vanilla button color mixins
78aa27a
@kirsty-hames
apply legacy styles if Vanilla button styles aren't supported
719cf2c
@kirsty-hames
extend on button selector classes to prevent Vanilla styles overwritting
df89c18 
- generic .btn-text and .btn-icon styles in Vanilla button.less
- same issue applies to Hint master. Plugin styles are being overwritten by Vanilla.
@kirsty-hames kirsty-hames self-assigned this Feb 12, 2025
swashbuck
swashbuck approved these changes Jun 23, 2025
View reviewed changes

@swashbuck swashbuck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster
oliverfoster merged commit 0286831 into master Jun 24, 2025
@oliverfoster
oliverfoster deleted the issue/32 branch June 24, 2025 12:08
github-actions Bot pushed a commit that referenced this pull request Jun 24, 2025
@semantic-release-bot
Chore(release): 4.2.0 [skip ci]
5339da2 
# [4.2.0](v4.1.0...v4.2.0) (2025-06-24)

### Chore

* Add support for new issue experience (fixes #31) (#35) ([5afd6b7](5afd6b7)), closes [#31](#31) [#35](#35)

### New

* Added support for new Vanilla button color mixins (fixes #32) (#33) ([0286831](0286831)), closes [#32](#32) [#33](#33)
@github-actions

github-actions Bot commented Jun 24, 2025

Copy link
Copy Markdown

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swashbuck swashbuck swashbuck approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels

enhancement released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sync with Adapt Buttons update

4 participants

@kirsty-hames @swashbuck @danielghost @oliverfoster