fix: apply ticks.format to the value 0#12260
Open
harukikuri wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11905
Ticks.formatters.numericreturned the literal'0'for a zero tick, short-circuiting beforeformatNumber. As a result a configuredticks.format(e.g.{ style: 'currency', currency: 'USD' }or{ style: 'percent' }) was ignored only for the value0— an axis would render0instead of$0/0%, while every other tick was formatted correctly.Zero now flows through
formatNumberwith the configured format, but withminimumFractionDigits/maximumFractionDigitsforced to0and handled before the scientific-notation logic. This preserves the existing behavior (plain0, no decimals, no scientific notation) when no format is set, while applying the format when one is provided.Test plan
test/specs/core.ticks.tests.js:ticks.format(currency / percent) is applied to0→$0,0%0stays0(no decimals; and no0E0even for huge ranges)core.ticksspec passes on Chrome (6/6).