[core] Allow for domains to use connect operators#5320
Open
seldridge wants to merge 1 commit into
Open
Conversation
Allow for domains to be connected using the standard connection operators. This matches behavior for properties and probes which do not support connects in FIRRTL, but instead allow for Chisel connections which then lower to these. This avoids a slightly sharp edge where previously connection operators could be used, e.g., `:<=`, but their use would result in a Chisel runtime error. Assisted-by: pi.dev:claude-opus-4-7 Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
adkian-sifive
approved these changes
May 14, 2026
Member
adkian-sifive
left a comment
adkian-sifive
left a comment
There was a problem hiding this comment.
LGTM but not knowing anything about domain implementation I wonder if the referential equality is good enough for the trait domain.Type -- that is, should this actually be erroring if two domains are structurally equivalent but with different instantiations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for domains to be connected using the standard connection operators.
This matches behavior for properties and probes which do not support
connects in FIRRTL, but instead allow for Chisel connections which then
lower to these.
This avoids a slightly sharp edge where previously connection operators
could be used, e.g.,
:<=, but their use would result in a Chisel runtimeerror.
Assisted-by: pi.dev:claude-opus-4-7
Release Notes
Add support for connection operators for domains. Previously, only
domain.definecould be used to connect domains.