Skip to content

[Scala3] Move ConnectableSpec #5387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adkian-sifive wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −5
Open

[Scala3] Move ConnectableSpec #5387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4388d3
Move ConnectableSpec
adkian-sifive May 28, 2026
8013608
Formatting
adkian-sifive May 28, 2026
b65fe2a
Update propsed name to handle Scala 3 null values
adkian-sifive May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions core/src/main/scala/chisel3/Module.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,11 +714,19 @@ package experimental {
*
* Includes the module prefix for user-defined modules (but not for blackboxes).
*/
private[chisel3] def _proposedName: String = this match {
// PseudoModules (e.g. Instances) and BlackBoxes have their names set by desiredName.
case _: PseudoModule => desiredName
case _: BaseBlackBox => desiredName
case _ => this.modulePrefix + desiredName
private[chisel3] def _proposedName: String = {
val dn = desiredName
// Handle Scala 3 null values
if (dn == null)
throw new NullPointerException(
s"desiredName of ${this.getClass.getName} is null"
)
this match {
// PseudoModules (e.g. Instances) and BlackBoxes have their names set by desiredName.
case _: PseudoModule => dn
case _: BaseBlackBox => dn
case _ => this.modulePrefix + dn
}
}

/** Legalized name of this module. */
Expand Down
0 ...scala-2/chiselTests/ConnectableSpec.scala → ...t/scala/chiselTests/ConnectableSpec.scala
View file
Open in desktop
File renamed without changes.
Loading