[Scala3] Move BlackBoxSpec and ChiselStageSpec#5394
Open
adkian-sifive wants to merge 4 commits into
Open
Conversation
jackkoenig
reviewed
May 29, 2026
Comment on lines
+34
to
+36
| trait HasMonitorSocket { this: RawModule => | ||
| protected def makeProbe(bundle: ProtocolBundle): ProtocolBundle = { | ||
| val monProbe = IO(probe.Probe(chiselTypeOf(bundle))) | ||
| val monProbe = chisel3.IO(probe.Probe(chiselTypeOf(bundle))) |
Contributor
There was a problem hiding this comment.
Can you explain why this is necessary?
Member
Author
There was a problem hiding this comment.
I've pulled this change into #5396, will comment there and undo this change
Member
Author
There was a problem hiding this comment.
But re other similar changes in this pr: Scala 3 cannot get access to IO with the selftype pattern
trait Something { this: RawModule => ...
and hits this error: illegal access to protected method IO in class BaseModule from trait Something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix IO disambiguation which doesn't work in Scala 3 and other issues
Release Notes
Move BlackboxSpec, ChiselStageSpec
Development notes