Skip to content

Provide basic openapi instances - #23

Open
worm2fed wants to merge 4 commits into
chordify:masterfrom
worm2fed:worm2fed/provide-openapi-instances
Open

Provide basic openapi instances#23
worm2fed wants to merge 4 commits into
chordify:masterfrom
worm2fed:worm2fed/provide-openapi-instances

Conversation

@worm2fed

Copy link
Copy Markdown

Initial issue was raised here: biocad/servant-openapi3#45

After some investigation I figured out, that to achieve this in proper way I need to make 3 PRs

  1. Add description to response headers biocad/servant-openapi3#48
  2. Use full header type in response header instances haskell-servant/servant#1697
  3. this one

NOTE: this PR (if accepted) must be merged at least after second one (to servant)

worm2fed added 2 commits July 19, 2023 23:11
This is impossible to achieve this on client side, because response
headers defined in library.
This is required to be able work with `servant-client`

@ysangkok ysangkok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a round trip test/

Comment thread src/Servant/Pagination.hs Outdated
@worm2fed

Copy link
Copy Markdown
Author

@ysangkok I'm stuck with ContentRange tests, there is restriction in type definition ToHttpApiData (RangeType resource field) which leads to error

• No instance for (ToHttpApiData
                         (RangeType Resource "fieldA 1..5"))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants