Freeze trim characters ahead of PHP 8.6#751
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.6 adds the form feed character to the default
$charactersset oftrim,ltrim, andrtrim, so calls relying on the default would change behavior there. This change passes the pre-8.6 set explicitly at the six call sites that relied on it, in the Linux binary auto-discovery, keyboard key normalization, and the browser process output handling, keeping behavior identical on every PHP version. An audit of the rest of the package found nothing else to fix: the remaining patterns already carry the PCREDmodifier or use no end anchor, and everypreg_matchfailure path fails closed.