Skip to content

[b/571727492] - Custom Parser for CLOUDFLARE_GATEWAY_DNS_GUS - #1411

Merged
chanduc-ux merged 8 commits into
mainfrom
CLOUDFLARE_custome_parser
Oct 28, 2026
Merged

chanduc-ux merged 8 commits into
mainfrom
CLOUDFLARE_custome_parser

Conversation

@chanduc-ux

@chanduc-ux chanduc-ux commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Description

As per the Customer request we have created the custom parser for the below Logtype.
Log_type:
CLOUDFLARE_GATEWAY_DNS_GUS


Checklist:

Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.

General Checks:

  • I have read and followed the project's contributing.md guide.
  • My code follows the project's coding style guidelines.
  • I have performed a self-review of my own code.
  • My changes do not introduce any new warnings.
  • My changes pass all existing tests.
  • I have added new tests where appropriate to cover my changes. (If applicable)
  • I have updated the documentation where necessary (e.g., README, API docs). (If applicable)

Open-Source Specific Checks:

  • My changes do not introduce any Personally Identifiable Information (PII) or sensitive customer data.
  • My changes do not expose any internal-only code examples, configurations, or URLs.
  • All code examples, comments, and messages are generic and suitable for a public repository.
  • I understand that any internal context or sensitive details related to this work are handled separately in internal systems (Buganizer for Google team members).

For Google Team Members and Reviewers Only:

  • I have included the Buganizer ID in the PR title or description (e.g., "Internal Buganizer ID: 123456789" or "Related Buganizer: go/buganizer/123456789").
  • I have ensured that all internal discussions and PII related to this work remain in Buganizer.
  • I have tagged the PR with one or more labels that reflect the pull request purpose.

Screenshots (If Applicable)

If your changes involve UI or visual elements, please include screenshots or GIFs here.
Ensure any sensitive data is redacted or generalized.


Further Comments / Questions

Any additional comments, questions, or areas where you'd like specific feedback.
SKIP_GOOGLE_PARSER_CHECK="Not Applicable for now"

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new custom parser for Cloudflare Gateway DNS logs. The implementation enables the parsing of JSON-formatted logs into the Unified Data Model (UDM), facilitating better visibility and security analysis for this specific log source.

Highlights

  • New Parser Implementation: Added a custom parser for the CLOUDFLARE_GATEWAY_DNS_GUS log type to support ingestion and normalization of Cloudflare Gateway DNS logs.
  • Metadata and Test Data: Included the necessary metadata configuration and test datasets (raw logs and expected UDM events) to validate the new parser.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Logstash parser configuration, metadata, and test data for Cloudflare Gateway DNS logs. The review feedback highlights a critical syntax error in the parser configuration where equals signs (=) were used instead of hash rockets (=>) in replace blocks. Additionally, the log_type in metadata.json needs to be updated to match the parser directory name exactly. Finally, there are opportunities to simplify and optimize the configuration by directly accessing the first element of the QueryApplicationNames and ResolvedIPCountryCodes arrays instead of using loops.

dongari-uday
dongari-uday previously approved these changes Oct 26, 2026
@chanduc-ux chanduc-ux changed the title [b/571727492] - Custom Parser for NETCRAFT_TAKEDOWN_GUS CLOUDFLARE_GATEWAY_DNS_GUS [b/571727492] - Custom Parser for CLOUDFLARE_GATEWAY_DNS_GUS Oct 26, 2026
Signed-off-by: chanduc-ux <chandu_chalamalla@epam.com>
Signed-off-by: chanduc-ux <chandu_chalamalla@epam.com>
Signed-off-by: chanduc-ux <chandu_chalamalla@epam.com>
Signed-off-by: chanduc-ux <chandu_chalamalla@epam.com>
dongari-uday
dongari-uday previously approved these changes Oct 27, 2026
Signed-off-by: chanduc-ux <chandu_chalamalla@epam.com>
Signed-off-by: chanduc-ux <chandu_chalamalla@epam.com>
@chanduc-ux
chanduc-ux merged commit b871bb7 into main Oct 28, 2026
52 checks passed
@chanduc-ux
chanduc-ux deleted the CLOUDFLARE_custome_parser branch October 28, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants