ci: [sc-19289] bump Go matrix and golangci-lint to match go.mod toolchain - #12
Merged
Conversation
Contributor
Author
|
Merged with administrator privileges, authorised by Jinsoo Heo on 2026-08-11. Recording the bypass explicitly for the audit trail: branch protection on main requires one approving review, and GitHub forbids a PR author approving their own PR, so the review requirement could not be satisfied by the author. Change is CI-only (Go matrix 1.21.x to 1.24.x, golangci-lint v1.53 to v2.12.2) and was verified green on this PR before merge. Ref [sc-19289]. |
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the Dependabot security PR keeman#11 (golang.org/x/crypto 0.41.0 to 0.52.0), which is failing CI for a reason unrelated to the bump.
Problem: the CI matrix pins Go 1.21.x and golangci-lint v1.53 (2023), while go.mod declares
go 1.23.0withtoolchain go1.24.6. Go therefore downloads the newer toolchain and emits export data the old lint binary cannot parse, so the lint step dies with:followed by cascading bogus typecheck errors (undefined: ethereum, undefined: bip39, undefined: ssb). This is pre-existing CI staleness, not a regression from any dependency, and it will block every future security update in this repo until fixed.
Change:
Acceptance: this PR's own lint and test run goes green, then keeman#11 reruns green and can merge, clearing 7 criticals in this repo.
Note: golangci-lint v2 may surface pre-existing findings that v1.53 never evaluated. If it does, they are real and get fixed or explicitly excluded in a follow-up rather than by reverting this.
Ref: [sc-19289]