Fix empty task in worker subquery with reference or schema sharded#8519
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-12.1 #8519 +/- ##
=============================================
Coverage 89.65% 89.66%
=============================================
Files 276 276
Lines 59790 59822 +32
Branches 7471 7476 +5
=============================================
+ Hits 53605 53639 +34
+ Misses 4041 4039 -2
Partials 2144 2144 🚀 New features to boost your workflow:
|
The backported issue_8243 test failed check-multi on release-12.1 for two reasons: 1. Test 6 EXPLAIN output was lifted from main and contained planner decorations release-12.1 does not emit (a Memoize node and btint4cmp(hashint8(...)) hash-range pruning predicates). Scope Test 6 with `SET enable_memoize TO off;` / `RESET enable_memoize;` and regenerate expected/issue_8243.out so it matches the release-12.1 planner. The real assertions (3 tasks / 2 tasks) are unchanged. 2. multi_schedule referenced a non-existent test `issue_7891` (no sql/expected files), which aborted pg_regress. Remove the dangling reference; keep issue_8243. Verified locally: check-minimal EXTRA_TESTS=issue_8243 -> 8/8 PASS, no regression.diffs (PG 16.14). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ihalatci
added a commit
that referenced
this pull request
Jun 30, 2026
…1) (#8629) ## Problem The 1ES self-hosted pool (`1es-gha-citusdata-pool`) is no longer dispatching jobs, so the **required** `check-arbitrary-configs` jobs sit `QUEUED` indefinitely. This blocks **every** open release-12.1 PR (#8519, #8328, #8306, #8626, #8627) from merging despite all other required checks passing. ## Fix Flip the `test-arbitrary-configs` job's `runs-on` from the dead self-hosted 1ES pool to `ubuntu-latest` — a one-line backport of the config already shipping on `main`. ## Why it is safe - `main` already runs this exact job/suite/container on `ubuntu-latest`. - Required-check **names** (`PG14 - check-arbitrary-configs-0`, ...) derive from the job `name:`, not `runs-on`, so branch protection is unaffected. - AC was the **only** job still pinned to the self-hosted pool; everything else already runs github-hosted. ## Rollout Merge this first, then "Update branch" on the 5 open PRs so they inherit the fix and their AC checks run on github-hosted runners. Unblocks the release-12.1 serial-merge queue. Co-authored-by: Ibrahim Halatci <ihalatci@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: fixes incorrect ignoring of reference or schema sharded tables in worker subquery task construction, when there are no distributed tables involved.
Fixes issue #8243, #8453
(cherry picked from commit b22e977)