Skip to content

refactor(repo): Improve sandbox layout#8605

Merged
jacekradko merged 7 commits into
mainfrom
carp/sandbox-improvements
May 21, 2026
Merged

refactor(repo): Improve sandbox layout#8605
jacekradko merged 7 commits into
mainfrom
carp/sandbox-improvements

Conversation

@alexcarpenter
Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 20, 2026

🦋 Changeset detected

Latest commit: d00202a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 20, 2026 9:11pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR centralizes sandbox controls into a Tweakpane-powered initControls(), adds appearance/variable defaults, refactors routing into a declarative mountableRoutes map (including a shared mountOpenButton), and updates Clerk.load() to apply initial variables or theme with a variables-first fallback. The HTML template now unconditionally loads Tailwind 4, defines theme variables and dark-mode behavior, and replaces static sidebar links with a NavLink custom element.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'refactor(repo): Improve sandbox layout' directly relates to the changeset, which refactors sandbox files (app.ts and template.html) to improve layout, routing, and theme/appearance handling.
Description check ✅ Passed The PR description contains only the repository's standard template with no actual implementation details, but the title and changeset context indicate the PR is about sandbox improvements, making it sufficiently related.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 20, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8605

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8605

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8605

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8605

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8605

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8605

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8605

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8605

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8605

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8605

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8605

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8605

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8605

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8605

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8605

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8605

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8605

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8605

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8605

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8605

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8605

commit: d00202a

@jacekradko jacekradko merged commit 135b8e0 into main May 21, 2026
43 checks passed
@jacekradko jacekradko deleted the carp/sandbox-improvements branch May 21, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants