Skip to content

chore(clerk-js): remove redundant dequal dependency#8608

Open
jacekradko wants to merge 1 commit into
mainfrom
jacek/aisec-32-f-281-clerkclerk-js-remove-redundant-dequal-runtime
Open

chore(clerk-js): remove redundant dequal dependency#8608
jacekradko wants to merge 1 commit into
mainfrom
jacek/aisec-32-f-281-clerkclerk-js-remove-redundant-dequal-runtime

Conversation

@jacekradko
Copy link
Copy Markdown
Member

@jacekradko jacekradko commented May 21, 2026

Nothing in @clerk/clerk-js imports dequal directly. It was listed as a direct runtime dependency but is only reached transitively through @clerk/shared (useDeepEqualMemo). Drop it from packages/clerk-js/package.json and the lockfile, with a patch changeset.

Resolves AISEC-32. Thanks to @7188ce06 for reporting.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 21, 2026 1:17am

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 21, 2026

🦋 Changeset detected

Latest commit: da41d04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jacekradko jacekradko marked this pull request as ready for review May 21, 2026 01:28
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4beb8193-50da-4ef3-94de-b3018c3d7026

📥 Commits

Reviewing files that changed from the base of the PR and between 4696c51 and da41d04.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • .changeset/remove-clerk-js-dequal.md
  • packages/clerk-js/package.json

📝 Walkthrough

Walkthrough

This PR removes a redundant direct dequal dependency from the @clerk/clerk-js package. The dequal package is no longer used directly by this package and has been removed from the dependencies list in package.json. A changeset file documents this removal as a patch-level change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore(clerk-js): remove redundant dequal dependency' clearly and specifically summarizes the main change: removing an unnecessary dependency from the clerk-js package.
Description check ✅ Passed The description directly relates to the changeset, clearly explaining why dequal is being removed (it's not directly imported) and how it's accessed (transitively through @clerk/shared).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 21, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8608

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8608

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8608

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8608

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8608

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8608

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8608

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8608

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8608

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8608

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8608

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8608

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8608

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8608

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8608

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8608

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8608

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8608

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8608

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8608

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8608

commit: da41d04

@wobsoriano
Copy link
Copy Markdown
Member

wobsoriano commented May 21, 2026

@jacekradko, this PR will use dequal 😃 #8587

(I already reviewed and approved the PR, but if you have bandwidth for a quick scan, Id appreciate it.)

@alexcarpenter alexcarpenter self-requested a review May 21, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants