fix(server-nestjs): protect system GitLab repos by topic, cover observability - #2608
Merged
Conversation
shikanime
marked this pull request as ready for review
August 26, 2026 17:00
shikanime
force-pushed
the
fix/gitlab-system-repos-purge
branch
from
August 26, 2026 17:06
2557121 to
15c7be6
Compare
Contributor
|
🤖 Hey ! A preview of the application is available at : https://console-pr-2608.dso.cpin-hp.numerique-interieur.fr Please be patient, deployment may take a few minutes. |
shikanime
force-pushed
the
fix/gitlab-system-repos-purge
branch
from
August 26, 2026 17:24
2aeff4b to
2595d8a
Compare
shikanime
force-pushed
the
fix/gitlab-system-repos-purge
branch
from
August 26, 2026 17:27
2595d8a to
4b9ed20
Compare
shikanime
changed the title
shikanime
force-pushed
the
fix/gitlab-system-repos-purge
branch
2 times, most recently
from
August 26, 2026 17:42
1bcf034 to
c8fd4f3
Compare
StephaneTrebel
previously approved these changes
Aug 27, 2026
StephaneTrebel
left a comment
StephaneTrebel
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, mais une question me taraude
shikanime
force-pushed
the
fix/gitlab-system-repos-purge
branch
from
August 27, 2026 09:16
c8fd4f3 to
a6273bd
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
shikanime
force-pushed
the
fix/gitlab-system-repos-purge
branch
from
August 27, 2026 09:22
ebc9cfe to
28bf737
Compare
…or) on reconciliation
shikanime
force-pushed
the
fix/gitlab-system-repos-purge
branch
from
August 27, 2026 09:31
28bf737 to
4d61a53
Compare
…meout to constants
shikanime
enabled auto-merge
August 27, 2026 12:49
StephaneTrebel
approved these changes
Aug 27, 2026
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
shikanime
added a commit
that referenced
this pull request
Aug 27, 2026
shikanime
added a commit
that referenced
this pull request
Aug 27, 2026
shikanime
added a commit
that referenced
this pull request
Aug 27, 2026
shikanime
added a commit
that referenced
this pull request
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
#2607
Quel est le comportement actuel ?
Lors d'un reprovisionnement de projet, le service GitLab
purgeOrphanRepossupprime tous les dépôts portant le topicplugin-managedabsents deproject.repositories. Les dépôts systèmeinfra-appsetmirrorsont créés avec ce topic mais n'apparaissent jamais dansproject.repositories, donc ils sont supprimés à chaque réconciliation. La recréation ultérieure échoue avec une erreur400 already marked for deletion(suppression GitLab asynchrone), ce qui rejette toute l'opération.Quel est le nouveau comportement ?
isSystemRepoprotège désormais explicitementinfra-appsetmirrorpar leur nom, en plus des dépôts déclarés dansproject.repositories. Les suppressions sont en outre rendues tolérantes aux erreurs : une suppression GitLab déjà en cours n'échoue plus toute la réconciliation du projet.Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Régression introduite par
a47e7b0e(« delete owned GitLab repos on explicit repository deletion »), présente surorigin/main. Test de non-régression ajouté :gitlab.service.spec.tsvérifie queinfra-appsetmirrorne sont jamais supprimés.