chore(server-nestjs): rename role readonly to reader - #2654
Open
shikanime wants to merge 2 commits into
Open
Conversation
- Rename READONLY_* constants to READER_* across all server-nestjs modules (argocd, gitlab, nexus, registry, sonarqube, vault) - Rename oidcGroup paths from /console/readonly to /console/reader - Update AdminRole name from 'Lecture Seule Plateforme' to 'Lecteur Plateforme' - Update ProjectRole name from 'Lecture seule' to 'Lecteur' - Update French descriptions from 'lecture seule' to 'lecteur' - Add Prisma migration 20260615100000_rename_role_readonly_to_reader to rename existing roles in database - Update old server queries.ts for consistency - Update shared permissions labels from 'Lecture seule globale' to 'Lecture globale' - Update external plugins/argocd/src/infos.ts constants and oidcGroups Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio> Co-authored-by: Automata <automata@shikanime.studio>
The infos.ts rename from readonly to reader was not reflected in functions.ts and functions.spec.ts, causing TypeScript compilation errors on the argocd plugin build. - Rename imports/aliases from READONLY to READER - Rename config keys platformReadonlyGroupPath -> platformReaderGroupPath - Rename config keys projectReadonlyGroupPathSuffix -> projectReaderGroupPathSuffix - Rename values keys platformReadonlyGroup -> platformReaderGroup - Rename values keys projectReadonlyGroup -> projectReaderGroup Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio> Co-authored-by: Automata <automata@shikanime.studio>
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Aucune
Quel est le comportement actuel ?
Les rôles de type
readonlyutilisent les chemins OIDC suivants :/console/readonlypour les rôles de projet/readonlypour les rôles admin de plateformeLes constantes sont nommées
READONLY_*et les libellés français utilisent"lecture seule".
Quel est le nouveau comportement ?
Les rôles sont renommés de
readonlyàreader:/console/readonlyà/console/readeret de/readonlyà/readerREADONLY_*deviennentREADER_*Lecture Seule PlateformedevientLecteur PlateformeLecture seuledevientLecture(cohérent avec leserveur legacy)
Fichiers modifiés (22) :
apps/server-nestjs/: constantes, services, specs, utils pour tous lesmodules (argocd, gitlab, nexus, registry, sonarqube, vault, project)
apps/server-nestjs/src/prisma/migrations/20260615100000_rename_role_readonly_to_reader/migration.sql: migration DBapps/server/src/resources/project/queries.ts: cohérence serveur legacypackages/shared/src/utils/permissions.ts: libellés partagésplugins/argocd/src/infos.ts: plugin externeCette PR introduit-elle un breaking change ?
Oui — Les chemins OIDC
/console/readonlyet/readonlysont renommés en/console/readeret/reader. Les groupes Keycloak correspondants, lespolitiques Vault, et les configurations de plugins externes (ArgoCD, Nexus,
SonarQube, Registry, GitLab) doivent être réconciliés. La migration Prisma
gère la mise à jour des rôles existants en base, mais les groupes externes
(Keycloak, Vault) seront synchronisés automatiquement par les jobs de
réconciliation des plugins.
Procédure de migration :
20260615100000_rename_role_readonly_to_reader)OIDC externes avec les nouveaux chemins
readonlyversreaderAutres informations
WHEREsur les anciennes valeurs)