Conversation
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Id70a61f1f608dce42c2cd149c7aebb766a6a6964
shikanime
marked this pull request as ready for review
September 17, 2026 10:34
shikanime
marked this pull request as draft
September 17, 2026 10:38
shikanime
commented
Sep 17, 2026
| } | ||
|
|
||
| # ── Routes par défaut (pour l'instant dans le legacy) ───────────────────────── | ||
| location /api/v1/stages { |
Member
Author
There was a problem hiding this comment.
🔴 bug: location /api/v1/stages bascule vers server-nestjs sans module stages côté NestJS sur cette branche (recréée de #2497 fermée, partie serveur jamais mergée) → 404 sur toutes les routes stages. Ajouter le module stages NestJS dans cette passe ou avant.
shikanime
commented
Sep 17, 2026
| } | ||
|
|
||
| # ── Routes par défaut (pour l'instant dans le legacy) ───────────────────────── | ||
| location /api/v1/stages { |
Member
Author
There was a problem hiding this comment.
🔵 nit: bloc migré rangé sous l'entête « Routes par défaut (pour l'instant dans le legacy) » — section mensongère. Déplacer sous « Routes migrées vers NestJS » comme en #2739.
shikanime
marked this pull request as ready for review
September 24, 2026 08:44
Member
Author
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (24.10% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Refs #1889
Quel est le comportement actuel ?
Les routes
stages(/api/v1/stages) sont servies par l'ancienne application Fastifyapps/servervia le nginx strangler, alors que le module NestJSStageModuleest enregistré et à parité.Quel est le nouveau comportement ?
Offload du routage
/api/v1/stagesde l'ancien serveur versserver-nestjsdansapps/nginx-strangler/conf.d/routing.conf(bloc placé en section migrée, aprèsservice-chains).Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Suppose la fusion de #2496 (module
stage) : la bascule n'est valide qu'après. Rollback selon le README : commenter le bloc (# ROLLBACK AAAA-MM-JJ) puisnginx -s reload.