Conversation
The VaultSysMount preamble restated the response shape ("returns one entry
per mount path") before its actual rationale. Drop the restatement and keep
the rationale: keyed by mount path; only the fields the console relies on
are typed, because engine-specific keys vary with the server version.
Comment-only change, no executable code touched.
Follow-up to #2768 (merged
before this cleanup landed; its branch was deleted at merge), delivered as
a small PR off main.
Deliberately kept:
- `// @Cron(CronExpression.EVERY_HOUR)` — deactivation marker shared by all
reconciler modules; out of scope for this trim.
- The `force_no_cache` note — documents a Vault v2.0.3 constraint verified
for #2762.
Verified: pnpm build and pnpm test green on the baseline and on this
commit; comment-stripped comparison against 61a236d shows identical code.
Refs #2762
Related: #2768
Co-authored-by: Automata <automata@shikanime.studio>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: I09e5481f2b5dcf3329b91de8618861446a6a6964
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (53.90% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Refs #2762
Quel est le comportement actuel ?
Le préambule de
VaultSysMount(apps/server-nestjs/src/modules/vault/vault-client.service.ts) reformule la forme de la réponse desys/mounts(« une entrée par chemin de mount ») avant sa seule information utile : pourquoi une partie seulement des champs est typée. La phrase est redondante avec le code et avec la discussion de revue de #2768.Quel est le nouveau comportement ?
Le commentaire ne conserve que la justification, resserrée sur 2 lignes : clé = chemin de mount ; seuls les champs exploités par la console sont typés, Vault ajoutant des clés propres au moteur (
plugin_version, ...) qui varient selon la version du serveur. Aucune ligne de code exécutable n'est modifiée.Suivi de la PR #2768 (fusionnée) : la branche d'origine a été supprimée à la fusion, ce nettoyage arrive donc en PR séparée, sans aucun autre changement.
Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Vérifications locales (node 26.7.0 / pnpm 11.8.0, mêmes commandes avant/après) :
pnpm build: exit 0 ;pnpm test: exit 0 ; totaux identiques (dont server-nestjs : 680 passed, 69 skipped).removeComments+ lignes commentaires retirées → identique au commit61a236d4.Commentaires volontairement conservés :
// @Cron(CronExpression.EVERY_HOUR)— marqueur de désactivation partagé par tous les modules de réconciliation (gitlab, argocd, nexus, registry, sonarqube, keycloak, vault) ; hors périmètre de ce nettoyage.force_no_cache— documente une contrainte Vault v2.0.3 vérifiée (rappelée dans 🐛 [BUG] - server-nestjs : réconciliation du mount KV Vault journalise le cas nominal en warn (400 path is already in use) #2762 et fix(vault): probe mount with GET and tune existing mounts #2768).