Skip to content

[codex] Normalize routing paths for Windows#2137

Closed
WilliamK112 wants to merge 1 commit into
cloudflare:mainfrom
WilliamK112:fix/windows-routing-path-normalization
Closed

[codex] Normalize routing paths for Windows#2137
WilliamK112 wants to merge 1 commit into
cloudflare:mainfrom
WilliamK112:fix/windows-routing-path-normalization

Conversation

@WilliamK112

Copy link
Copy Markdown
Contributor

Summary

Part of #1605.

  • normalize file scanner and convention-file probe paths to forward slashes for internal routing use
  • keep Pages Router and App Router route construction in forward-slash path space on Windows
  • update route graph helpers/tests so pagePath, layoutPath, errorPath, slot paths, and scanner output are validated with normalized separators

Validation

  • corepack pnpm test tests/windows-path-normalization.test.ts tests/app-route-graph.test.ts tests/routing.test.ts tests/route-sorting.test.ts
  • corepack pnpm run fmt:check
  • corepack pnpm run check

@WilliamK112

Copy link
Copy Markdown
Contributor Author

Closing this stale draft as superseded by #2502, which covers the broader Windows path normalization/pathslash migration and is from the contributor who took #1605 in the issue thread. This branch is also now conflicting with main, so keeping it open would add duplicate review noise.

@WilliamK112 WilliamK112 closed this Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant